fix: skip adding authorizer to event if no authorizer is configured #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DorianMazur i have another one for you to 👀 ! |
DorianMazur
reviewed
May 17, 2024
|
|
||
| if (!endpoint.authorizer) { | ||
| log.debug("no authorizer configured, deleting authorizer payload") | ||
| delete event.requestContext.authorizer |
There was a problem hiding this comment.
I think this will collide with customizations.offline?.customAuthenticationProvider, that's why tests are failing.
DorianMazur
reviewed
May 17, 2024
Co-authored-by: Dorian <46839236+DorianMazur@users.noreply.github.com>
|
thank you! i ran a limited set of the tests locally until it worked so i must have missed customAuthenticationProvider |
DorianMazur
changed the title
DorianMazur
changed the title
cnuss
added a commit
to scaffoldly/serverless-offline
that referenced
this pull request
May 19, 2024
* master: refactor: use provided log utils (dherault#1784) fix: skip adding authorizer to event if no authorizer is configured (dherault#1786) Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS API Gateway does not include the
event.requestContext.authorizerfield if there is noauthorizerconfigured for the function.This PR deletes the
event.requestContext.authorizerfield if the function does not have an authorizer.Motivation and Context
authorizerpayload didn't match what it expectedserverless-offlinewas always settingevent.requestContext.authorizerif aBearertoken comes through in the HTTP Authorization headers.event.requestContext.authorizerif the lambda function does not have anauthorizerset.How Has This Been Tested?
I've written tests and included them in this PR. Please let me know if you want me to kick the tires in any other ways!