You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is auto-generated from hashicorp#21378 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
Description
This resolves an ambiguous dependency resolution in consul-ui in the event that a developer attempted to yarn install or npm install from a non-workspace-root directory. This handles it in two ways:
Namespaces with a @hashicorp/ prefix, reducing the risk of a hypothetical public registry squat situation should local packages ever stop being relative
Explicitly locally dependency-links packages
Something to note with this is that the packages become a little more bound together than before; for example, it would be more difficult to maintain multiple valid versions of a sub-package here and let consul-ui differentiate between them. We could expand this into submodules some day, but not today.
Backport
This PR is auto-generated from hashicorp#21378 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
Description
This resolves an ambiguous dependency resolution in consul-ui in the event that a developer attempted to
yarn install
ornpm install
from a non-workspace-root directory. This handles it in two ways:@hashicorp/
prefix, reducing the risk of a hypothetical public registry squat situation should local packages ever stop being relativeSomething to note with this is that the packages become a little more bound together than before; for example, it would be more difficult to maintain multiple valid versions of a sub-package here and let
consul-ui
differentiate between them. We could expand this into submodules some day, but not today.Overview of commits
The text was updated successfully, but these errors were encountered: