Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of fix(v2dns): add node ttl to workloads, comment cleanup, and changelog into release/1.18.x #965

Open
3 of 4 tasks
dhiaayachi opened this issue Sep 27, 2024 · 0 comments
Open
3 of 4 tasks

Backport of fix(v2dns): add node ttl to workloads, comment cleanup, and changelog into release/1.18.x #965

dhiaayachi opened this issue Sep 27, 2024 · 0 comments

Comments

@dhiaayachi
Copy link
Owner

Backport

This PR is auto-generated from hashicorp#20643 to be assessed for backporting due to the inclusion of the label backport/1.18.

The below text is copied from the body of the original PR.

Description

This PR started out as comment cleanup but ended up including some functional changes, including eliminating some unused fields and adding the Node TTLs to Workloads (which was discussed previously with Keeler).

The changelog for V2 DNS is also included here.

Testing & Reproduction steps

  • CI

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhiaayachi