-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: general configuration, application layout and directory structure #1
feat: general configuration, application layout and directory structure #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the name cached-resources
is not really descriptive, it's rather technical. Also, it's not really caching, it's just a wrapper for loading the values and providing them to the rest of the app via context, The data itself is actually "meta data", unfortunately that term already has meaning in the dhis2 context, but it's some form of contextual data. I'm not sure myself what a better description is, but I'd like to raise awareness about this kind of naming in general (e. g. auth-wall
is way more descriptive and therefore any dev knows what to expect, at least to some extend)
Co-authored-by: Jan-Gerke Salomon <Mohammer5@users.noreply.github.com>
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR is a combination of DHIS2-11283 and DHIS2-11284 plus includes a lot of general project configuration:
use-query-params
andprop-types
A few points to take into consideration when reviewing:
shared
folder in thesrc
dir.use-query-params
.loading
orerror
state into account.