feat: handle different period types of workflow and data sets (DHIS2-11288) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
reviewed
Jul 21, 2021
|
|
||
| return { | ||
| ds: dataSetId, | ||
| pe: periodIds.join(','), |
There was a problem hiding this comment.
.join shouldn't be needed here as the runtime does it for us here
Mohammer5
force-pushed
the
DHIS2-11288-Handle-diff-periodType-of-wf-and-ds
branch
from
7784dbf to
86716b5
Compare
mediremi
approved these changes
Jul 27, 2021
dhis2-bot
added a commit
that referenced
this pull request
Jul 27, 2021
# [1.9.0](v1.8.1...v1.9.0) (2021-07-27) ### Features * handle different period types of workflow and data sets (DHIS2-11288) ([#30](#30)) ([ae990e1](ae990e1))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DHIS2-11288
(link)
I've added some refactoring to this PR:
loading || !called(when params exist) is true (as!calledbasically means it's about to load)