feat: resolve ignorefile for stylelint #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismay
commented
May 21, 2024
| const cmd = 'stylelint' | ||
| const cwd = PACKAGE_ROOT | ||
| const args = [...(apply ? ['--fix'] : []), ...files] | ||
| const args = [ | ||
| '--report-needless-disables', |
There was a problem hiding this comment.
We do this for eslint as well, so I've also added it here.
tomzemp
approved these changes
May 22, 2024
dhis2-bot
added a commit
that referenced
this pull request
May 22, 2024
## [10.7.1](v10.7.0...v10.7.1) (2024-05-22) ### Bug Fixes * document ignorefile for stylelint ([#468](#468)) ([bb133b2](bb133b2))
|
🎉 This PR is included in version 10.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/browse/DHIS2-16776. I've just added the docs for it, stylelint already handles this properly without any extra code required.