Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update headerbar to latest and greatest #31

Merged
merged 1 commit into from
Dec 13, 2019
Merged

fix: update headerbar to latest and greatest #31

merged 1 commit into from
Dec 13, 2019

Conversation

varl
Copy link
Contributor

@varl varl commented Dec 13, 2019

Since @ismay is working on a larger refactor of this application, this relies on the existing hacks to make it work.

@varl varl requested a review from Birkbjo December 13, 2019 09:21
Copy link

@erikarenhill erikarenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the app locally and saw the headerbar working. Don't know so much about the app otherwise so see my review more as a smoke test.

@varl varl merged commit 293a52c into master Dec 13, 2019
@varl varl deleted the ui/headerbar branch December 13, 2019 15:55
dhis2-bot added a commit that referenced this pull request Dec 1, 2020
# 1.0.0 (2020-12-01)

### Bug Fixes

* add translations for new job types ([#25](#25)) ([404b04c](404b04c))
* only throw job run error if there are error reports ([f3d468a](f3d468a))
* revert to old translation strategy ([a795c21](a795c21))
* update headerbar to latest and greatest ([#31](#31)) ([293a52c](293a52c))
* use human readable cron label strings ([a64a151](a64a151))

### Features

* **scheduling types:** support both cron and delay scheduling types ([e14ccd8](e14ccd8))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants