-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSR fails on npm version step in workspaces #112
Comments
Similar issues raises in yarn 2+. We use a module.exports = {
branch: 'master',
plugins: [
[
'@semantic-release/commit-analyzer',
{
preset: 'angular',
releaseRules: [
{type: 'docs', release: 'patch'},
{type: 'refactor', release: 'patch'},
],
parserOpts: {
noteKeywords: ['BREAKING CHANGE', 'BREAKING CHANGES']
}
}
],
'@semantic-release/release-notes-generator',
'@semantic-release/changelog',
[
'@semantic-release/exec',
{
prepareCmd: 'YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install && git add ../../yarn.lock',
}
],
'@semrel-extra/npm',
'@semantic-release/github'
... |
@antongolub thank you for the suggestion! I was actually able to get it to work by running |
Great! Maybe you'd lke to add some notes to the readme.md troubleshooting section? |
Sure thing, how bout this #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After NPM V8.5 MSR fails to properly version packages.
The cause seems to be rooted in NPM version here.
npm/cli@723a091
npm version now triggers an update. This causes MSR to fail because it hasn't updated the version numbers to the packages workspace dependencies.
Since this behavior is now default, would need to some how get a --no-workspaces-update to semantic releases use of npm version in
https://github.com/semantic-release/npm/blob/master/lib/prepare.js#L12
The text was updated successfully, but these errors were encountered: