Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find packages when nohoist is configured #21

Open
StevenLangbroek opened this issue Jul 16, 2020 · 4 comments · Fixed by #23
Open

Can't find packages when nohoist is configured #21

StevenLangbroek opened this issue Jul 16, 2020 · 4 comments · Fixed by #23

Comments

@StevenLangbroek
Copy link
Contributor

Hey folks! We're running into a little issue:

We've configured nohoist to deal with some Typescript malarkey. In our root package.json, workspaces looks like this:

  "workspaces": {
    "packages": [
      "packages/core",
      "packages/react"
    ],
    "nohoist": [
      "**/react-native",
      "**/react-native/**"
    ]
  },

This leads to this error:

[multi-semantic-release]: TypeError: package.json: workspaces: Must be non-empty array of string

Should this be supported? We can work around this for now by feeding it the path of projects manually by using the programmatic API, but if you think it's something that should work I'd gladly submit a fix.

Thanks ❤️

@StevenLangbroek
Copy link
Contributor Author

StevenLangbroek commented Jul 16, 2020

Ok so the fix seems pretty straightforward and I'd gladly contribute it back if you're interested in fixing this.

@antongolub
Copy link
Collaborator

@StevenLangbroek, any feedback, ideas or improvements are appreciated.
Feel free to open PR as soon as you wish.

@dhoulb
Copy link
Owner

dhoulb commented Jul 16, 2020

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@antongolub
Copy link
Collaborator

antongolub commented Jul 16, 2020

Misclicked when I closed the issue.

@antongolub antongolub reopened this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants