Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks to be incompatible with sem-rel versions upper than 15.13.27 #7

Closed
antongolub opened this issue Oct 26, 2019 · 2 comments
Closed

Looks to be incompatible with sem-rel versions upper than 15.13.27 #7

antongolub opened this issue Oct 26, 2019 · 2 comments
Labels
released

Comments

@antongolub
Copy link
Collaborator

antongolub commented Oct 26, 2019 •
edited
Loading

@dhoulb Hi, Dave.

semantic-release got a big patch of its own deps, fixes, and It looks like it somehow affected multi-sem-rel.

Here is what I can note:

There're a pair of meaningful troubles:

  • tagFormat option is detected as invalid
  • semantic-release finds that "command is not executed from the root of the cloned repository"

As a quick workaround, we can just lock the highest working semantic-release version in multi-sem-rel deps or in projects, for example, through yarn resolution hook:

  "resolutions": {
    "multi-semantic-release/semantic-release": "15.13.24"
  },
@antongolub antongolub changed the title Looks to be incompatible with sem-rel versions upper than 15.13.24 Looks to be incompatible with sem-rel versions upper than 15.13.27 Oct 26, 2019
@antongolub
Copy link
Collaborator Author

antongolub commented Oct 27, 2019 •
edited
Loading

@dhoulb Well, the most significant change is related to execa update. So after the version sync and minor fixes, everything works fine: 133715321.

Here's the patch: #9.

qiwibot referenced this issue in qiwi/multi-semantic-release Nov 3, 2019
@qiwibot
chore(release): 1.1.0 [skip ci]
070ccfc 
# [1.1.0](v1.0.3...v1.1.0) (2019-11-03)

### Bug Fixes

* **package:** add missed sem-rel plugins ([f3c9318](f3c9318))
* **package:** update execa to be compatible with sem-rel 15.13.28 ([069bb4e](069bb4e)), closes [#7](#7)
* force a release ([1e3ece5](1e3ece5))

### Features

* add execasync CLI flag to make execa calls be always synchronous ([693438c](693438c)), closes [#1](#1)
@dhoulb dhoulb closed this as completed in 069bb4e Nov 4, 2019
@dhoulb
Copy link
Owner

dhoulb commented Nov 4, 2019

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhoulb dhoulb added the released label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhoulb @antongolub