Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdVault with too many ads not rendering - "tab unresponsive" #2504

Open
mneunomne opened this issue Jan 14, 2024 · 2 comments
Open

AdVault with too many ads not rendering - "tab unresponsive" #2504

mneunomne opened this issue Jan 14, 2024 · 2 comments

Comments

@mneunomne
Copy link
Collaborator

Too many ads on my vault are failing to render, it makes the tab timeout.

It seems to crash at around 3000 ads being displayed at the same time.

Image of the vault (not all ads being displayed):

Screenshot 2024-01-15 at 00 07 43
@mneunomne mneunomne self-assigned this Jan 14, 2024
@mneunomne mneunomne changed the title AdVault with too many ads not crashing the tab. AdVault with too many ads not rendering - crashing the tab. Jan 14, 2024
@mneunomne mneunomne changed the title AdVault with too many ads not rendering - crashing the tab. AdVault with too many ads not rendering - "tab unresponsive". Jan 14, 2024
@mneunomne mneunomne changed the title AdVault with too many ads not rendering - "tab unresponsive". AdVault with too many ads not rendering - "tab unresponsive" Jan 14, 2024
@dhowe
Copy link
Owner

dhowe commented Jan 16, 2024

A couple of options here, long and short term, respectively:

  1. rewrite the D3 code to be cleaner/more efficient (it is quite a mess right now)
  2. restrict the number of ads users can view at one time

@ashkitten
Copy link

I ran a profiler on the process while it was working on rendering the ad vault. We spend most of our time doing rectangle packing, specifically checking if one rectangle contains another in order to merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants