-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release PyPI update on successful CI run/tag #32
Conversation
.travis.yml
Outdated
- pip install flake8 pytest-cov pytest coveralls | ||
- pip install -e . | ||
|
||
- pip install flake8 pytest-cov pytest coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment about list entries.
.travis.yml
Outdated
- pytest --cov=trustymail | ||
- flake8 . | ||
|
||
- pytest --cov=trustymail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment about list entries.
.travis.yml
Outdated
- '3.5' | ||
- '3.6' | ||
|
||
- '3.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These list entries should be indented two spaces for readability. I'm not sure if YML requires or or not, but it's the standard thing to do.
.travis.yml
Outdated
after_success: | ||
- coveralls | ||
- coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment about list entries.
.travis.yml
Outdated
after_success: | ||
- coveralls | ||
- coveralls | ||
deploy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on TravisCI, but this looks correct.
One question: Does TravisCI know to update the __version__
string in __init__
appropriately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, Travis will push out a tagged commit: https://docs.travis-ci.com/user/deployment/pypi/#Deploying-tags
(Coveralls has been tuned with comparable settings to pshtt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Add python_requires argument for setup.py
…n_and_checkout_action Update Python and actions/checkout Versions
Using instructions from docs.travis-ci.com and robinandeer.com, this change tells Travis to deploy a new version to PyPI after a successful run + a new tag on master.
(Note that the minor reformatting is courtesy of
$ travis setup pypi
.)