Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Invalid Conventional Commit format when using GitMojis #417

Open
chrispoupart opened this issue Sep 12, 2024 · 0 comments
Open

[Bug]: Invalid Conventional Commit format when using GitMojis #417

chrispoupart opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@chrispoupart
Copy link

Opencommit Version

3.2.2

Node Version

22.8.0

NPM Version

10.8.2

What OS are you seeing the problem on?

Mac

What happened?

Currently, when using Conventional Commits with the Gitmoji feature, the Gitmojis are added to the beginning of the first line of the commit message, like this:

🎉 feat(README.md): add comprehensive documentation on how to install, use, contribute, license and contact the project

However, this is not compliant with a lot of other tools that rely on the conventional commit standard (semantic-release being a big one), because it is not compliant with the Conventional Commits spec.

Expected Behavior

Tools like the VSCode Conventional Commit Extension and their equivalents for other IDEs create compatible commits by moving the gitmoji to the description part of the message, which would make it look like this:

feat(README.md): 🎉 add comprehensive documentation on how to install, use, contribute, license and contact the project

Current Behavior

As per the above, the gitmoji at the beginning of the line breaks conventional commit parsing on other tools.

Possible Solution

Ideally, I think that changing this as the default behaviour when using the combination of gitmoji and conventional commits would make the most sense, as it mirrors the other tools already on the market.

Barring that, a configuration option allowing people to switch between the formats would be helpful.

I'm happy try my hand at a PR if this is a change that you are interested in.

Steps to Reproduce

No response

Relevant log output

No response

@chrispoupart chrispoupart added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant