Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale if rx,ry,xAxisRot are such that there is no solution #3

Open
kasbah opened this issue Nov 16, 2014 · 3 comments
Open

Scale if rx,ry,xAxisRot are such that there is no solution #3

kasbah opened this issue Nov 16, 2014 · 3 comments

Comments

@kasbah
Copy link
Contributor

kasbah commented Nov 16, 2014

I thought I'd open an issue for this as it's marked as TODO in the code anyway and I have started working on this seperately.

If you do a cabal run in my project though you can see that the second property won't pass quickcheck. Sometimes this is due to floating point errors (which seem to exceed ieee754) but sometimes there are NaNs in the result which indicates there is no solution although I think I scale rx,ry as described.

Just wondering if you had any ideas and also if you would be interested to use my implementation if I get it to work.

@tkvogt
Copy link
Member

tkvogt commented Nov 16, 2014

I will replace the TODO list with issues. Yes I am intereseted to use your code. But can I/we copy it into Path.hs? I don't want to upload a separate library to hackage for 100 lines. SVG parsing is certainly full of possible bugs and I am grateful for help.

@kasbah
Copy link
Contributor Author

kasbah commented Nov 16, 2014

Yeah sure, I only packaged it for ease of testing. Any ideas on why it doesn't find solutions even though it is scaled though?

I posted this on StackOverflow too.

@kasbah
Copy link
Contributor Author

kasbah commented Nov 16, 2014

OK, figured out the issue so patches are incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants