Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better star polygons when p,q are not relatively prime #7

Closed
fryguybob opened this issue Aug 4, 2012 · 2 comments
Closed

Better star polygons when p,q are not relatively prime #7

fryguybob opened this issue Aug 4, 2012 · 2 comments
Labels
duplicate enhancement

Comments

@fryguybob
Copy link
Member

(Imported from http://code.google.com/p/diagrams/issues/detail?id=9. Original issue from byor...@gmail.com on December 27, 2010, 12:21:31 AM UTC)

See starPolygon in D.TwoD.Shapes. Currently it doesn't really work when its arguments are not relatively prime. For example, starPolygon 6 2 ought to generate a Star of David but currently just generates a doubly-traced equilateral triangle.
@fryguybob
Copy link
Member Author

(Imported. Original comment by byor...@gmail.com on May 10, 2011, 06:55:45 PM UTC)

Dima sent me some code for this, need to find time to merge it into the repo.

@fryguybob
Copy link
Member Author

(Imported. Original comment by byor...@gmail.com on June 19, 2011, 05:45:24 PM UTC)

See Issue #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fryguybob