Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for the dashboard #641

Closed
cwmeijer opened this issue Oct 3, 2023 · 3 comments
Closed

Create tests for the dashboard #641

cwmeijer opened this issue Oct 3, 2023 · 3 comments
Assignees

Comments

@cwmeijer
Copy link
Member

cwmeijer commented Oct 3, 2023

There is at least a single test already but unsure what it does.
We want at least one test per dashboard page testing the default case.

@cwmeijer cwmeijer self-assigned this Oct 3, 2023
@cwmeijer
Copy link
Member Author

cwmeijer commented Oct 3, 2023

Tests were created in #567
They test exactly what was asked in this issue 🎉

However, one test is failing at the moment.
image
https://github.com/dianna-ai/dianna/actions/runs/6185615330/job/16791555535

@cwmeijer
Copy link
Member Author

cwmeijer commented Oct 3, 2023

I can't replicate the error just starting the dashboard locally and following the steps in the test manually.
image
The error in the failing test suggests that there is no text 'RISE' visible. It is there however when I run it, see screenshot.

@cwmeijer
Copy link
Member Author

I think @geek-yang already fixed it while with #649 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant