Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] The fate of load-graph #1005

Closed
SensibleSalmon opened this issue May 15, 2015 · 3 comments
Closed

[Discussion] The fate of load-graph #1005

SensibleSalmon opened this issue May 15, 2015 · 3 comments

Comments

@SensibleSalmon
Copy link
Contributor

In the spirit of 93c47ec and since #961 is nearly mergable and since I'm about to shift focus from oxli to UX stuff and I don't want build-graph to be left behind while additional changes are made, would it be possible to delete load-graph entirely and redirect everything that used it to build-graph? As it stands I've taken every test in the unit test suite that uses load-graph (even indirectly) and made versions that use build-graph, so in theory it's trustworthy.

@mr-c @ctb @luizirber @camillescott thoughts?

@mr-c
Copy link
Contributor

mr-c commented May 15, 2015

This could be part of the upcoming API breakage release.

@SensibleSalmon
Copy link
Contributor Author

@ctb Thoughts on this, since said release is supposedly in the works?

@ctb
Copy link
Member

ctb commented Jun 30, 2015

As per #961, load-graph was replaced by the contents of build-graph; there is no build-graph script. If you're proposing to now go back in and rename load-graph to build-graph, please make a case for it in a new issue :).

@ctb ctb closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants