Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of optimal hash size calculation to khmer.khmer_args #390

Closed
ctb opened this issue Apr 17, 2014 · 8 comments
Closed

Add implementation of optimal hash size calculation to khmer.khmer_args #390

ctb opened this issue Apr 17, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@ctb
Copy link
Member

ctb commented Apr 17, 2014

@qingpeng, can you take a first stab at adding a function into khmer to calculate the optimal H and Z parameters for a CountMin Sketch at a given fp rate for a given N? Don't worry about argparse inclusion or anything -- just a function with some unit tests.

@qingpeng
Copy link
Contributor

OK.

@ctb
Copy link
Member Author

ctb commented Apr 23, 2014

Actually, reading through the section in the paper, I think we should have two functions: one that calculates the correct Z and H given M (-N and -x given desired memory usage) and one that calculates the Z and H given f and N. Then when the HLL comes on line (hah!) we can make use of the latter. /cc @luizirber

@mr-c
Copy link
Contributor

mr-c commented Jul 30, 2014

@qingpeng & @luizirber Any update on this?

@mr-c mr-c added this to the unscheduled milestone Sep 2, 2014
@mr-c mr-c added the Python label Sep 2, 2014
@ctb
Copy link
Member Author

ctb commented Sep 16, 2014

Scenarios --

  • not useful for digital normalization, where we want to know how many k-mers are left AFTER diginorm;
  • useful for partitioning

Anything else?

@mr-c
Copy link
Contributor

mr-c commented Oct 1, 2014

Still useful for diginorm as it can provide a lower ceiling for memory usage if number of k-mers is previously known.

@proteasome
Copy link
Contributor

@mr-c i'm interested in working on this

@ctb
Copy link
Member Author

ctb commented Jun 28, 2015

Added in #1106.

@ctb
Copy link
Member Author

ctb commented Jul 18, 2015

Fixed by #1126.

@ctb ctb closed this as completed Jul 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants