-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of optimal hash size calculation to khmer.khmer_args #390
Comments
OK. |
Actually, reading through the section in the paper, I think we should have two functions: one that calculates the correct Z and H given M (-N and -x given desired memory usage) and one that calculates the Z and H given f and N. Then when the HLL comes on line (hah!) we can make use of the latter. /cc @luizirber |
@qingpeng & @luizirber Any update on this? |
Scenarios --
Anything else? |
Still useful for diginorm as it can provide a lower ceiling for memory usage if number of k-mers is previously known. |
@mr-c i'm interested in working on this |
Added in #1106. |
Fixed by #1126. |
@qingpeng, can you take a first stab at adding a function into khmer to calculate the optimal H and Z parameters for a CountMin Sketch at a given fp rate for a given N? Don't worry about argparse inclusion or anything -- just a function with some unit tests.
The text was updated successfully, but these errors were encountered: