Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root all of our C++ exceptions to a common base exception #508

Closed
mr-c opened this issue Jun 25, 2014 · 3 comments
Closed

Root all of our C++ exceptions to a common base exception #508

mr-c opened this issue Jun 25, 2014 · 3 comments

Comments

@mr-c
Copy link
Contributor

mr-c commented Jun 25, 2014

lib/perf_metrics.hh:struct InvalidPerformanceMetricsKey : public std:: exception {
lib/khmer.hh:struct InvalidStreamBuffer : public std:: exception {
lib/khmer.hh:class khmer_file_exception : public std::exception
lib/read_parsers.hh:struct CacheSegmentUnavailable : public std:: exception {
lib/read_parsers.hh:struct CacheSegmentBoundaryViolation : public std:: exception {
lib/read_parsers.hh:struct InvalidCacheSizeRequested : public std:: exception {
lib/read_parsers.hh:struct NoMoreReadsAvailable : public std:: exception {
lib/read_parsers.hh:struct UnknownPairReadingMode : public std:: exception {
lib/read_parsers.hh:struct InvalidReadPair : public std:: exception {
lib/thread_id_map.hh:struct InvalidNumberOfThreadsRequested : public std:: exception {
lib/thread_id_map.hh:struct TooManyThreads : public std:: exception {

This is good from an API standpoint and helps us in the Python glue code

@mr-c mr-c added this to the 1.1.1+ Release milestone Jun 25, 2014
@mr-c mr-c added the C++ label Jul 17, 2014
@iglpdc
Copy link
Contributor

iglpdc commented Jul 22, 2014

I'm working in this issue as part of the ScienceLab Sprint.

@mr-c
Copy link
Contributor Author

mr-c commented Jul 22, 2014

Great. The common base exception should also be the base for khmer::khmer_file_exception

@mr-c
Copy link
Contributor Author

mr-c commented Jul 31, 2014

This was completed in #554

@mr-c mr-c closed this as completed Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants