Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize screed and khmer read record details #769

Closed
ctb opened this issue Feb 11, 2015 · 7 comments
Closed

Synchronize screed and khmer read record details #769

ctb opened this issue Feb 11, 2015 · 7 comments
Labels
Milestone

Comments

@ctb
Copy link
Member

ctb commented Feb 11, 2015

khmer.ReadParser returns read objects that differ from screed-created read objects in silly ways; this should be fixed.

@ctb
Copy link
Member Author

ctb commented Feb 11, 2015

One question - is it OK for a legitimate read to have an empty quality attribute?

@mr-c
Copy link
Contributor

mr-c commented Feb 20, 2015

Note: ReadParser reads still refer to 'accuracy'

@ctb
Copy link
Member Author

ctb commented Feb 20, 2015

See also #645

@ctb
Copy link
Member Author

ctb commented Jun 13, 2015

Needs to be verified.

@mr-c
Copy link
Contributor

mr-c commented Jun 13, 2015

ReadParser reads do correctly refer to 'quality' instead of 'accuracy'

Reads from FASTA files still have an 'accuracy' attribute (an empty UTF string).

In [6]: o = khmer.ReadParser('tests/test-data/paired.fa')

In [7]: n = o.next()

In [8]: n.
n.annotations  n.name         n.quality      n.sequence  

In [9]: n.quality
Out[9]: u''

@betatim
Copy link
Member

betatim commented Oct 24, 2016

Has the opinion on exposing the Read object "fully" changed since #645? Motivation for doing so would be to make it easy to test that screed.Record and khmer.Read look and feel the same.

@ctb
Copy link
Member Author

ctb commented Oct 25, 2016

On Mon, Oct 24, 2016 at 07:02:46AM -0700, Tim Head wrote:

Has the opinion on exposing the Read object "fully" changed since #645? Motivation for doing so would be to make it easy to test that screed.Record and khmer.Read look and feel the same.

Yes, I think it's a good idea for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants