Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up khmer.calc_expected_collisions() output in khmer/__init__.py #980

Closed
4 tasks done
ctb opened this issue Apr 26, 2015 · 4 comments
Closed
4 tasks done

clean up khmer.calc_expected_collisions() output in khmer/__init__.py #980

ctb opened this issue Apr 26, 2015 · 4 comments
Labels
low-hanging-fruit Python
Milestone
2.0

Comments

@ctb
Copy link
Member

ctb commented Apr 26, 2015

  • every line should start with **
  • the false positive rate should be printed out
  • the max false positive rate should be printed out
  • 'presence table' isn't always correct, eg. load-into-counting; remove 'presence'
@mr-c
Copy link
Contributor

mr-c commented Apr 28, 2015

@ctb Is this a blocker for v1.4?

@ctb
Copy link
Member Author

ctb commented Apr 28, 2015

On Tue, Apr 28, 2015 at 10:07:15AM -0700, Michael R. Crusoe wrote:

@ctb Is this a blocker for v1.4?

nope.

@ctb ctb mentioned this issue May 31, 2015
Merged
12 tasks
@ctb
Copy link
Member Author

ctb commented Jul 18, 2015

Confirm fix for 2.0; close.

@ctb ctb added this to the 2.0 milestone Jul 18, 2015
@ctb
Copy link
Member Author

ctb commented Jul 19, 2015

Confirmed!

@ctb ctb closed this as completed Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging-fruit Python
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@ctb @mr-c