Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load-graph multithreaded test doesn't assert anything #998

Open
SensibleSalmon opened this issue May 13, 2015 · 1 comment
Open

load-graph multithreaded test doesn't assert anything #998

SensibleSalmon opened this issue May 13, 2015 · 1 comment
Assignees
@johnsolk
Labels
low-hanging-fruit Python theme:best-practices
Milestone
2.1

Comments

@SensibleSalmon
Copy link
Contributor

https://github.com/ged-lab/khmer/blob/master/tests/test_scripts.py#L1012

the test just runs the script which means the only failure case is if the script explodes and throws exceptions everywhere--it doesn't actually check to see if threading was done or done properly.
@johnsolk
Copy link
Member

I am working on this issue.

@johnsolk johnsolk self-assigned this Jul 22, 2015
@mr-c mr-c added this to the 2.0+ milestone Jul 30, 2015
@johnsolk johnsolk mentioned this issue Aug 13, 2015
Open
@standage standage modified the milestones: 2.1, 2.0+ Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnsolk johnsolk

Labels
low-hanging-fruit Python theme:best-practices
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
4 participants
@standage @mr-c @SensibleSalmon @johnsolk