Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling non-ACGT chars #3

Open
mr-eyes opened this issue Aug 6, 2019 · 2 comments
Open

Handling non-ACGT chars #3

mr-eyes opened this issue Aug 6, 2019 · 2 comments

Comments

@mr-eyes
Copy link
Member

mr-eyes commented Aug 6, 2019

Illustrate in details how does it work.
And how it handles non ACGT characters.
@mr-eyes
Copy link
Member Author

mr-eyes commented Nov 17, 2021

kmerDecoder auto converts any non-ACGT character to "A".

@mr-eyes mr-eyes closed this as completed Nov 17, 2021
@mr-eyes mr-eyes mentioned this issue Nov 17, 2021
Closed
@mr-eyes mr-eyes changed the title Methods Handling non-ACGT chars Nov 17, 2021
@drtamermansour
Copy link
Member

I would suggest ignoring the non-ACGT kmers instead.
Changing the kmers might cause false positive results in some cases e.g. containment use cases

@mr-eyes mr-eyes reopened this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drtamermansour @mr-eyes