Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hopeless misstrokes #621

Open
Monniasza opened this issue Dec 30, 2024 · 1 comment
Open

hopeless misstrokes #621

Monniasza opened this issue Dec 30, 2024 · 1 comment

Comments

@Monniasza
Copy link

Monniasza commented Dec 30, 2024

These two misstrokes have been missed in #199

Dictionary

I noticed this dictionary entry or these dictionary entries in:

  • dict.json

Misstroked entry or entries

These looks like misstrokes or could otherwise be better:

"HOEP/-FL/*F/-LS": "hopeless",
"HOEP/HRES": "hopeless"

HOEP/-FL/*F/-LS looks like a misstroke because:

  • Between the HOEP and -LS strokes there are also -FL and *F.
  • *F is a misstroke for "of"
  • -FL is a stroke for "{^ful}", which isn't part of the translation

HOEP/HRES looks like a misstroke because it uses a word stroke HRES instead of the suffix stroke -LS.

Expected

I would expect the outline to be:

"HOEP/-LS": "hopeless",

I would expect to see that outline because:

  • It uses a suffix stroke.
  • It is consistent with the main.json dictionary from Plover 3.

Even better

To make this even better, we could:

  • Remove the entries completely because they can already be stroked without their own entries.
  • Remove the stroke HRES for "{^less}" to be consistent with others.
@Monniasza Monniasza changed the title hopeless misstroke hopeless misstrokes Dec 30, 2024
@didoesdigital
Copy link
Owner

Thanks for all of these recent issues you've posted @Monniasza . I'm waiting on some work to be finished in the webapp before making dictionary changes so I can minimise the risk of multiple things changing at once but I'm very grateful for your efforts and will follow up on these as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants