Incorrect type for userAuthParams in setUserWithAuthParams

[johankasperi]

react-native/src/Didomi.ts

Line 616 in 90b94df

userAuthParams: UserAuthParams,

Shouldn't it be:

userAuthParams: UserAuthParams | UserAuthWithEncryptionParams | UserAuthWithHashParams

so the function accepts for example digest in the params?

[pmerlet-at-didomi]

Hello, UserAuthWithEncryptionParams and UserAuthWithHashParams both extend UserAuthParams. The function should accept digest without issue. Is it not the case?

[johankasperi]

Hello, UserAuthWithEncryptionParams and UserAuthWithHashParams both extend UserAuthParams. The function should accept digest without issue. Is it not the case?

No that is not the case. That is not how TypeScript functions. Just because UserAuthWithEncryptionParams and UserAuthWithHashParams extends UserAuthParams doesn't mean that the function accepts these types.

[johankasperi]

Hello, UserAuthWithEncryptionParams and UserAuthWithHashParams both extend UserAuthParams. The function should accept digest without issue. Is it not the case?

No that is not the case. That is not how TypeScript functions. Just because UserAuthWithEncryptionParams and UserAuthWithHashParams extends UserAuthParams doesn't mean that the function accepts these types.

If I find the time I can make a PR that fixes this

[pmerlet-at-didomi]

No pb, if this fixes the issue:

userAuthParams: UserAuthParams | UserAuthWithEncryptionParams | UserAuthWithHashParams

we can add it to the next release.

[johankasperi]

No pb, if this fixes the issue:

userAuthParams: UserAuthParams | UserAuthWithEncryptionParams | UserAuthWithHashParams

we can add it to the next release.

Yes that will fix the issue