-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToastrBox are not removed after timeout expiration #5
Comments
Can you please provide some information about the Browser you are using (name/version)? A bit strange as I don't have changed anything on this area, in the new version I just rename the repo and remove the "window" object because it was causing issues on the server-side rendering. About your questions.
|
I already provided information about the Browser in an edit.
Please, look the edits, the issue was finally related to the CSS, should I rename the issue or let it for users which may end up on the same issue as me? |
2: no You don't need to rename the issue.
and on your webpack.config.js handle the css file |
For a strange reason, ToastrBoxes are not removed after they expire (
setTimeout
triggers the remove handler).By debugging the code, I found out that this line: https://github.com/diegoddox/react-redux-toastr/blob/master/src/ToastrBox.js#L98 never calls the
onAnimationComplite
for an unknown reason.Fyi, I'm using React 0.14 and React-Redux-Toastr latest version, it seems to be a regression, because the old Redux-Toastr version worked fine for me. I had to upgrade (because I was using the github.io for the styles... it's my fault on this one >_<).
I'm not accustomed to CSSCore and low-level animation handlers to understand why this issue is happening, any idea?
EDIT: After looking Event Listeners on my DOM node (the message one), I see that the
animationend
andtransitionend
are registered for theonCSSTransitionEnd
(runOnce
) helper function.My questions are:
transitionend
or ananimationend
event?runOnce
throws something?runOnce
, do we really run it once? If no,e.stopPropagation()
may prevent the next handlers to get called, right?EDIT2:
Browser used: Chromium 48.0 64 bits under Arch Linux (updated & all the shiny stuff).
EDIT3:
This problem applies also to ToastrConfirm.
EDIT4:
The problem seems to be due to the fact that I was not using your CSS link rather, a copy of
react-redux-toastr.min.css
without any fonts, it is maybe related to this then.Then, the question is: "How to properly bundle your styles (assuming I'm using Webpack)?"
The text was updated successfully, but these errors were encountered: