Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEM CSS Classes are not completly updated #13

Open
Angelmmiguel opened this issue Jul 17, 2017 · 2 comments
Open

BEM CSS Classes are not completly updated #13

Angelmmiguel opened this issue Jul 17, 2017 · 2 comments

Comments

@Angelmmiguel
Copy link

Hello,

I tried to copy a Dashboard component into a new Configuration one. I use CSS BEM notation in this project, so CSS classes are like Dasboard__JobList. The issue is that classes are not updated:

render() {
  return <section className="Configuration">
    <Content>
      <Title>Jobs</Title>
      <div className="Dashboard__JobList">
        { /* ... */ }
      </div>
    </Content>
  </section>;
};

I'll create a PR soon solving this issue. Can you give me any hint to keep in mind for developing your library?

Thanks!

@diegohaz
Copy link
Owner

diegohaz commented Jul 17, 2017

Hey, @Angelmmiguel

I think just changing

new RegExp(`([^a-zA-Z0-9_$])${oldName}([^a-zA-Z0-9_$]|Container)`, 'g'),
should fix this, but it might require some testing.

@Angelmmiguel
Copy link
Author

Thanks for the hint! I'll try to solve it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants