Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for core-js3 & React 17! #1148

Closed
ivaylopetrovdev opened this issue Mar 15, 2021 · 5 comments
Closed

Support for core-js3 & React 17! #1148

ivaylopetrovdev opened this issue Mar 15, 2021 · 5 comments

Comments

@ivaylopetrovdev
Copy link

To Reproduce
Steps to reproduce the behavior including code snippet (if applies):
npm install @react-pdf/renderer
npm install core-js

Expected behavior

NOT to receive such error:
ERROR in ./node_modules/babel-runtime/core-js/promise.js
Module not found: Error: Can't resolve 'core-js/library/fn/promise' in 'project_path/node_modules/babel-runtime/core-js'
@ ./node_modules/babel-runtime/core-js/promise.js 1:30-67
@ ./node_modules/babel-runtime/helpers/asyncToGenerator.js
@ ./node_modules/page-wrapping/dist/page-wrapping.es.js
@ ./node_modules/@react-pdf/renderer/dist/react-pdf.browser.es.js
@ ./src/app/util/pdf-generator.worker.js

@ivaylopetrovdev ivaylopetrovdev changed the title Support for core-js3 Support for core-js3 & React 17! Mar 15, 2021
@ivaylopetrovdev
Copy link
Author

@diegomura please address this with highest priority :)

@princefishthrower
Copy link

@ivaylopetrovdev Made a pull request to bump react version here: #1157
You can meanwhile just fork this and issue npm update react, it works fine and then all tests pass, not sure where any maintainers are on this one, the original React 17 version issue was raised last October...

@ivaylopetrovdev
Copy link
Author

@ivaylopetrovdev Made a pull request to bump react version here: #1157
You can meanwhile just fork this and issue npm update react, it works fine and then all tests pass, not sure where any maintainers are on this one, the original React 17 version issue was raised last October...

@princefishthrower lovely, can't wait to see your PR merged so we can start using this :) Appreciate your efforts!

@KolbySisk
Copy link

Any updates on this? I'd like to use this with a new CRA project, but I'm unable to until React 17 is supported.

@diegomura
Copy link
Owner

Keeping #1062. It's confusing to keep the conversation in both sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants