Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Mismatch in PDFDownloadLink #2985

Open
yukikotani231 opened this issue Nov 26, 2024 · 2 comments
Open

Type Mismatch in PDFDownloadLink #2985

yukikotani231 opened this issue Nov 26, 2024 · 2 comments

Comments

@yukikotani231
Copy link

Describe the bug
The type definition for PDFDownloadLink in react-pdf (here) appears to be inconsistent with the actual function implementation in PDFDownloadLink.js (here).

This type mismatch was likely introduced in the previous commit. You can review the specific changes in the commit log (here).
@timeswind
Copy link

The latest release (4.1.5) indeed rise new typescript compiler warning in my project. Wonder what is the reason for the type changing.

@cdrrr
Copy link

cdrrr commented Dec 22, 2024

No fix already??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timeswind @cdrrr @yukikotani231