Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The changeset macro should be a compiler annotation #12

Closed
sgrif opened this issue Nov 28, 2015 · 0 comments
Closed

The changeset macro should be a compiler annotation #12

sgrif opened this issue Nov 28, 2015 · 0 comments
Milestone

Comments

@sgrif
Copy link
Member

sgrif commented Nov 28, 2015

Documenting in case anyone wants to get involved. This is the last macro being invoked from our integration tests that needs to go away for 0.1 I intend for this to be #[can_update="users"]. This annotation should basically do what the macro does today, including all columns, but should specifically exclude the primary key of the table from the changeset.

As part of this, I think we should group all our non-derive annotations into a single namespace with each just being a key/value pair. e.g. #[yaqb(inserable_into("users"), can_update("users"))]. That change should affect #[column_name] as well. That can be a separate PR that pre-dates this change, part of this change, or just not done at all. It's not a 0.1 blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant