Move side effect out of conditional

tautschnig · tautschnig · commit 53e35c26ee61 · 2018-06-24T10:14:54.000+01:00
The side effect is intentional, but compilers might rightfully warn about this.
diff --git a/src/cpp/parse.cpp b/src/cpp/parse.cpp
@@ -4020,7 +4020,9 @@ bool Parser::rArgDeclListOrInit(
   }
   else
   {
-    if((is_args=rArgDeclList(arglist)))
+    is_args = rArgDeclList(arglist);
+
+    if(is_args)
       return true;
     else
     {

Original file line number	Diff line number	Diff line change
`@@ -4020,7 +4020,9 @@ bool Parser::rArgDeclListOrInit(`
`4020`	`4020`	`}`
`4021`	`4021`	`else`
`4022`	`4022`	`{`
`4023`		`- if((is_args=rArgDeclList(arglist)))`
	`4023`	`+ is_args = rArgDeclList(arglist);`
	`4024`	`+`
	`4025`	`+ if(is_args)`
`4024`	`4026`	`return true;`
`4025`	`4027`	`else`
`4026`	`4028`	`{`