Use ranget map to get values

This allows `values` to be const and clarifies that this list is
a direct mapping from retained_values.

Author: romainbrenguier

src/pointer-analysis/value_set_dereference.cpp

@@ -31,6 +31,7 @@ Author: Daniel Kroening, kroening@kroening.com
 #include <util/pointer_predicates.h>
 #include <util/simplify_expr.h>
 #include <util/ssa_expr.h>
+#include <util/range.h>
 
 /// Returns true if \p expr is complicated enough that a local definition (using
 /// a let expression) is preferable to repeating it, potentially many times.
@@ -123,8 +124,6 @@ exprt value_set_dereferencet::dereference(const exprt &pointer)
       retained_values.push_back(value);
   }
 
-  std::list<valuet> values;
-
   exprt compare_against_pointer = pointer;
 
   if(retained_values.size() >= 2 && should_use_local_definition_for(pointer))
@@ -147,8 +146,9 @@ exprt value_set_dereferencet::dereference(const exprt &pointer)
   std::cout << '}' << std::endl;
 #endif
 
-  for(const auto &value : retained_values)
-    values.push_back(build_reference_to(value, compare_against_pointer, ns));
+  std::list<valuet> values =
+    make_range(retained_values).map([&](const exprt &value){
+      return build_reference_to(value, compare_against_pointer, ns);});
 
   // can this fail?
   bool may_fail;