goto-instrument/wmm: Use int for bit vector of Booleans

Using an unsigned type is an unnecessary type conversion.

Author: tautschnig

src/goto-instrument/wmm/abstract_event.cpp

@@ -100,7 +100,7 @@ bool abstract_eventt::unsafe_pair_lwfence_param(const abstract_eventt &next,
 
 bool abstract_eventt::unsafe_pair_asm(const abstract_eventt &next,
   memory_modelt model,
-  unsigned char met) const
+  int met) const
 {
   /* pairs with fences are not properly pairs */
   if(operation==operationt::Fence ||

src/goto-instrument/wmm/abstract_event.h

@@ -144,7 +144,7 @@ class abstract_eventt:public graph_nodet<empty_edget>
   bool unsafe_pair_asm(
     const abstract_eventt &next,
     memory_modelt model,
-    unsigned char met) const;
+    int met) const;
 
   std::string get_operation() const
   {
@@ -181,9 +181,9 @@ class abstract_eventt:public graph_nodet<empty_edget>
   bool is_direct() const { return WWfence || WRfence || RRfence || RWfence; }
   bool is_cumul() const { return WWcumul || RWcumul || RRcumul; }
 
-  unsigned char fence_value() const
+  int fence_value() const
   {
-    unsigned char value = WRfence + 2*WWfence + 4*RRfence + 8*RWfence
+    int value = WRfence + 2*WWfence + 4*RRfence + 8*RWfence
       + 16*WWcumul + 32*RWcumul + 64*RRcumul;
     return value;
   }

src/goto-instrument/wmm/event_graph.cpp

@@ -565,7 +565,7 @@ bool event_grapht::critical_cyclet::is_unsafe_asm(
 {
   egraph.message.debug() << "cycle is safe?" << messaget::eom;
   bool unsafe_met=false;
-  unsigned char fences_met=0;
+  int fences_met = 0;
 
   /* critical cycles contain at least 4 events */
   if(size()<4)