Fixed CMake linker ODR violations caused by a regression-test

Including .Cpp file in a regression-test was causing linker issues with CMake,
specifically ODR (One Definition Rule) violations. Commit addresses this by
modifying the test to include the header file instead.

Author: Degiorgio

src/java_bytecode/java_types.cpp

@@ -29,10 +29,6 @@ std::vector<typet> parse_list_types(
   const char opening_bracket,
   const char closing_bracket);
 
-size_t find_closing_semi_colon_for_reference_type(
-  const std::string src,
-  size_t starting_point = 0);
-
 typet java_int_type()
 {
   return signedbv_typet(32);

src/java_bytecode/java_types.h

@@ -82,6 +82,10 @@ std::vector<typet> java_generic_type_from_string(
 
 typet java_bytecode_promotion(const typet &);
 exprt java_bytecode_promotion(const exprt &);
+size_t find_closing_semi_colon_for_reference_type(
+  const std::string src,
+  size_t starting_point = 0);
+
 
 bool is_java_array_tag(const irep_idt &tag);
 bool is_valid_java_array(const struct_typet &);

unit/java_bytecode/java_utils_test.cpp

@@ -13,7 +13,7 @@
 
 #include <testing-utils/catch.hpp>
 
-#include <java_bytecode/java_types.cpp>
+#include <java_bytecode/java_types.h>
 #include <java_bytecode/java_utils.h>
 
 SCENARIO("Test that the generic signature delimiter lookup works reliably",