Merge pull request #4271 from tautschnig/pthread_cond_wait

pthread_cond_wait may return spuriously

Author: tautschnig

regression/cbmc-library/CMakeLists.txt

@@ -1,3 +1,13 @@
+if(NOT WIN32)
 add_test_pl_tests(
     "$<TARGET_FILE:cbmc>"
 )
+else()
+add_test_pl_tests(
+    "$<TARGET_FILE:cbmc>"
+    "cbmc-library"
+    "$<TARGET_FILE:cbmc>"
+    "-C;-X;pthread"
+    "CORE"
+)
+endif()

regression/cbmc-library/Makefile

@@ -1,10 +1,17 @@
 default: tests.log
 
+include ../../src/config.inc
+include ../../src/common
+
+ifeq ($(BUILD_ENV_),MSVC)
+	no_pthread = -X pthread
+endif
+
 test:
-	@../test.pl -e -p -c ../../../src/cbmc/cbmc
+	@../test.pl -e -p -c ../../../src/cbmc/cbmc $(no_pthread)
 
 tests.log: ../test.pl
-	@../test.pl -e -p -c ../../../src/cbmc/cbmc
+	@../test.pl -e -p -c ../../../src/cbmc/cbmc $(no_pthread)
 
 show:
 	@for dir in *; do \

regression/cbmc-library/pthread_barrier_destroy-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_barrier_init-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_barrier_wait-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_cancel-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_cond_broadcast-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_cond_init-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_cond_signal-01/test.desc

@@ -1,4 +1,4 @@
-KNOWNBUG
+KNOWNBUG pthread
 main.c
 --pointer-check --bounds-check
 ^EXIT=0$

regression/cbmc-library/pthread_cond_wait-01/main.c

@@ -1,9 +1,32 @@
 #include <assert.h>
-#include <pthread_lib.h>
+#include <pthread.h>
+
+pthread_mutex_t lock;
+pthread_cond_t cond;
+
+// only accessed in critical section guarded by mutex, so there is no need to
+// make this variable atomic or volatile
+int x;
+
+void *thread(void *arg)
+{
+  (void)arg;
+  pthread_mutex_lock(&lock);
+  pthread_cond_wait(&cond, &lock);
+  // may fail: pthread_cond_wait can be waken up spuriously (see man
+  // pthread_cond_wait)
+  assert(x == 1);
+  pthread_mutex_unlock(&lock);
+  return NULL;
+}
 
 int main()
 {
-  pthread_cond_wait();
-  assert(0);
-  return 0;
+  pthread_t t;
+  pthread_mutex_init(&lock, 0);
+  pthread_cond_init(&cond, 0);
+  pthread_create(&t, NULL, thread, NULL);
+  x = 1;
+  pthread_cond_broadcast(&cond);
+  pthread_join(t, NULL);
 }