Merge pull request #401 from thk123/bug/linter-inline-structs

More linter fixes

Author: tautschnig

CODING_STANDARD

@@ -17,6 +17,9 @@ Whitespaces:
   Exceptions: Spaces around &&, || and <<
 - Space after comma (parameter lists, argument lists, ...)
 - Space after colon inside 'for'
+- For pointers and references, the */& should be attached to the variable name
+  as oppposed to the tyep. E.g. for a pointer to an int the syntax would be:
+    `int *x;`
 - No whitespaces at end of line
 - No whitespaces in blank lines
 - Put argument lists on next line (and ident 2 spaces) if too long

regression/cpp-linter/class-decl-space/main.cpp

@@ -8,3 +8,36 @@ Author: Thomas Kiley, thomas@diffblue.com
 
 class temp_classt : public base_classt
 {}
+
+class another_class : public base_classt
+{}
+
+class more_class:public base_classt
+{}
+
+class nonderived
+{}
+
+class nonderivedt
+{}
+
+#define ID_property_class dstring(23, 0)
+
+int foo(class define);
+
+int foo(class definet);
+
+template <class U>
+void bar(U t);
+
+template<class U>
+void bar(U t);
+
+template < class U >
+void bar(U t);
+
+class testt
+{
+  template<class U>
+  void bar(U t);
+}

regression/cpp-linter/class-decl-space/test.desc

@@ -2,6 +2,13 @@ CORE
 main.cpp
 
 ^main\.cpp:9:  There shouldn.t be a space between class identifier and :  \[readability/identifiers\] \[4\]$
-^Total errors found: 1$
+^main\.cpp:12:  There shouldn.t be a space between class identifier and :  \[readability/identifiers\] \[4\]$
+^main\.cpp:12:  Class or struct identifier should end with t  \[readability/identifiers\] \[4\]$
+^main\.cpp:15:  Class or struct identifier should end with t  \[readability/identifiers\] \[4\]$
+^main\.cpp:18:  Class or struct identifier should end with t  \[readability/identifiers\] \[4\]$
+^main\.cpp:26:  Class or struct identifier should end with t  \[readability/identifiers\] \[4\]$
+^main\.cpp:30:  Remove spaces around <  \[whitespace/operators\] \[4\]$
+^main\.cpp:36:  Remove spaces around <  \[whitespace/operators\] \[4\]$
+^Total errors found: 8$
 ^SIGNAL=0$
 --

regression/cpp-linter/operator-spacing2/main.cpp

@@ -24,8 +24,11 @@ static void fun()
 
   int x = 1<<4;
 
+  // Ideally this should produce an error, see operator-spacing3
   status()<<"Adding CPROVER library ("<<eom;
 
   // Ideally this should produce an error, see operator-spacing3
   int x = 1 << 4;
+
+  int y = a<<b;
 }

regression/cpp-linter/operator-spacing2/test.desc

@@ -1,7 +1,7 @@
 CORE
 main.cpp
 
-^main\.cpp:27:  Missing spaces around <<  \[whitespace/operators\] \[3\]
-^Total errors found: 1$
+^Total errors found: 0$
+^EXIT=0$
 ^SIGNAL=0$
 --

regression/cpp-linter/operator-spacing3/main.cpp

@@ -27,4 +27,6 @@ static void fun()
   status()<<"Adding CPROVER library ("<<eom;
 
   int x = 1 << 4;
+
+  result=((result<<1)^it->hash())-result;
 }

regression/cpp-linter/pointer-type1/main.cpp

@@ -0,0 +1,37 @@
+/*******************************************************************\
+
+Module: Lint Examples
+
+Author: Thomas Kiley, thomas@diffblue.com
+
+\*******************************************************************/
+
+/*******************************************************************\
+
+Function: fun
+
+ Inputs:
+
+ Outputs:
+
+ Purpose:
+
+\*******************************************************************/
+
+static void fun()
+{
+  bool *x=nullptr; // Valid
+  bool* x=nullptr; // Invalid
+
+  int &x=nullptr; // Valid
+  int& x=nullptr; // Invalid
+
+  int y=at*bt; // Valid
+
+  // Probably valid - could be a pointer to type yt or a
+  // variable called yt multilied by z. Would have to know
+  // it is a function call rather than a function declaration
+  foo(
+    x,
+    yt*z);
+}

regression/cpp-linter/pointer-type1/test.desc

@@ -0,0 +1,8 @@
+CORE
+main.cpp
+
+^main\.cpp:24:  Pointer type name must have \* attached to the type name  \[whitespace/operators\] \[4\]$
+^main\.cpp:27:  Reference type name must have & attached to the type name  \[whitespace/operators\] \[4\]$
+^Total errors found: 2$
+^SIGNAL=0$
+--

regression/cpp-linter/struct-inline-decl/main.cpp

@@ -0,0 +1,24 @@
+/*******************************************************************\
+
+Module: Lint Examples
+
+Author: Thomas Kiley, thomas@diffblue.com
+
+\*******************************************************************/
+
+/*******************************************************************\
+
+Function: fun
+
+ Inputs:
+
+ Outputs:
+
+ Purpose:
+
+\*******************************************************************/
+
+static void fun()
+{
+  bar(struct mystructt& struct_var);
+}

regression/cpp-linter/struct-inline-decl/test.desc

@@ -0,0 +1,8 @@
+CORE
+main.cpp
+
+
+^Total errors found: 0$
+^EXIT=0$
+^SIGNAL=0$
+--