Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching to sass from node-sass #56

Closed
TheBosZ opened this issue Jul 3, 2018 · 2 comments
Closed

Consider switching to sass from node-sass #56

TheBosZ opened this issue Jul 3, 2018 · 2 comments

Comments

@TheBosZ
Copy link
Contributor

TheBosZ commented Jul 3, 2018

Since #54 has been merged and individual projects can choose which run time to use, it would be nice to switch the default from node-sass to sass.

Speed-wise, they seem to be about the same (according to the tests here: https://github.com/sass/dart-sass/blob/master/perf.md) and installing node-sass is always a pain.

For users who truly need node-sass, they can include it manually.
@differui
Copy link
Contributor

differui commented Jul 4, 2018

Hi @TheBosZ you are right. #54 only add runtime option but have not remove node-sass from dependiences we should install node-sass as before.

Thanks for the advice. I will switch to sass from node-sass.

@differui
Copy link
Contributor

differui commented Jul 5, 2018

new version 0.9.0

@differui differui closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBosZ @differui