Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested improvements to com.diffplug.eclipse.apt #117

Open
nedtwigg opened this issue Jan 27, 2020 · 0 comments
Open

suggested improvements to com.diffplug.eclipse.apt #117

nedtwigg opened this issue Jan 27, 2020 · 0 comments

Comments

@nedtwigg
Copy link
Member

The com.diffplug.eclipse.apt plugin is just copy-pasted with a few minor fixes from the https://github.com/tbroyer/gradle-apt-plugin, which is no longer maintained. It is no longer maintained because Gradle incorporated native support for annotation processing, so the plugin became extraneous. The one exception is gradle+eclipse, where annotation processing still requires this plugin.

Per advice from the original author, it would be good to remove the plugin DSL and extract annotation processor arguments from getAllCompilerArgs instead; and remove the AptSourceSetConvention, remove/inline AptPlugin52, and remove the AptPlugin altogether.

When/if eclipse.apt generates problems or deprecation warnings in a future release, I'll consider taking this on if it's the easiest way to fix them. So long as the current code works perfectly, it will not make the top of my todo list. If it makes the top of anyone else's todo list, I'll be happy to merge these improvements :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant