Call 'getProperty' can be simplified for 'line.separator'

Author: Vincent Potucek

lib-extra/src/groovy/java/com/diffplug/spotless/extra/glue/groovy/GrEclipseFormatterStepImpl.java

@@ -48,6 +48,8 @@
 import dev.equo.solstice.Solstice;
 import dev.equo.solstice.p2.CacheLocations;
 
+import static java.lang.System.lineSeparator;
+
 /** Spotless-Formatter step which calls out to the Groovy-Eclipse formatter. */
 public class GrEclipseFormatterStepImpl {
 	static {
@@ -143,7 +145,7 @@ public String toString() {
 			}
 			for (Throwable error : errors) {
 				error.printStackTrace();
-				string.append(System.lineSeparator());
+				string.append(lineSeparator());
 				string.append(error.getMessage());
 			}
 

lib/src/main/java/com/diffplug/spotless/Jvm.java

@@ -31,6 +31,8 @@
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
+import static java.lang.System.lineSeparator;
+
 /** Java virtual machine helper */
 public final class Jvm {
 	private static final int VERSION;
@@ -255,7 +257,7 @@ private String buildUpgradeFormatterMessage(V fmtVersion) {
 		public String toString() {
 			return String.format("%s alternatives:%n", fmtName) +
 					jvm2fmtMaxVersion.entrySet().stream().map(
-							e -> String.format("- Version %s requires JVM %d+", e.getValue(), e.getKey())).collect(Collectors.joining(System.lineSeparator()));
+							e -> String.format("- Version %s requires JVM %d+", e.getValue(), e.getKey())).collect(Collectors.joining(lineSeparator()));
 		}
 
 		@SuppressFBWarnings("SE_COMPARATOR_SHOULD_BE_SERIALIZABLE")

lib/src/main/java/com/diffplug/spotless/LineEnding.java

@@ -25,6 +25,8 @@
 import java.util.Objects;
 import java.util.function.Supplier;
 
+import static java.lang.System.lineSeparator;
+
 /**
  * Represents the line endings which should be written by the tool.
  */
@@ -151,7 +153,7 @@ static String getEndingFor(Reader reader) throws IOException {
 	private static final Policy UNIX_POLICY = new ConstantLineEndingPolicy(UNIX.str());
     private static final Policy MAC_CLASSIC_POLICY = new ConstantLineEndingPolicy(MAC_CLASSIC.str());
     private static final Policy PRESERVE_POLICY = new PreserveLineEndingPolicy();
-	private static final String _platformNative = System.getProperty("line.separator");
+	private static final String _platformNative = lineSeparator();
 	private static final Policy _platformNativePolicy = new ConstantLineEndingPolicy(_platformNative);
 	private static final boolean nativeIsWin = _platformNative.equals(WINDOWS.str());
 

lib/src/main/java/com/diffplug/spotless/generic/IndentStep.java

@@ -102,10 +102,14 @@ String format(String raw) {
 				if (numSpaces > 0) {
 					switch (state.type) {
 					case SPACE:
-						builder.append(" ".repeat(numSpaces));
+						for (int i = 0; i < numSpaces; ++i) {
+							builder.append(' ');
+						}
 						break;
 					case TAB:
-						builder.append("\t".repeat(Math.max(0, numSpaces / state.numSpacesPerTab)));
+						for (int i = 0; i < numSpaces / state.numSpacesPerTab; ++i) {
+							builder.append('\t');
+						}
 						if (mightBeMultiLineComment && (numSpaces % state.numSpacesPerTab == 1)) {
 							builder.append(' ');
 						}

lib/src/main/java/com/diffplug/spotless/pom/SortPomCfg.java

@@ -17,6 +17,8 @@
 
 import java.io.Serializable;
 
+import static java.lang.System.lineSeparator;
+
 // Class and members must be public, otherwise we get failed to access class com.diffplug.spotless.pom.SortPomInternalState from class com.diffplug.spotless.pom.SortPomFormatterFunc (com.diffplug.spotless.pom.SortPomInternalState is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @682bd3c4; com.diffplug.spotless.pom.SortPomFormatterFunc is in unnamed module of loader com.diffplug.spotless.pom.DelegatingClassLoader @573284a5)
 public class SortPomCfg implements Serializable {
 	private static final long serialVersionUID = 1L;
@@ -25,7 +27,7 @@ public class SortPomCfg implements Serializable {
 
 	public String encoding = "UTF-8";
 
-	public String lineSeparator = System.getProperty("line.separator");
+	public String lineSeparator = lineSeparator();
 
 	public boolean expandEmptyElements = true;
 

lib/src/main/java/com/diffplug/spotless/sql/dbeaver/DBeaverSQLFormatterConfiguration.java

@@ -67,7 +67,9 @@ public DBeaverSQLFormatterConfiguration(Properties properties) {
 	private String getIndentString(String indentType, int indentSize) {
 		char indentChar = indentType.equals("space") ? ' ' : '\t';
 		StringBuilder stringBuilder = new StringBuilder();
-		stringBuilder.append(String.valueOf(indentChar).repeat(Math.max(0, indentSize)));
+		for (int i = 0; i < indentSize; i++) {
+			stringBuilder.append(indentChar);
+		}
 		return stringBuilder.toString();
 	}