You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@fvgh Oh, I've just realised that it would be best to replace the [ \t] part of the regex with \s, since that will catch all whitespace according to https://regexone.com/lesson/whitespaces.
The reason will be displayed to describe this comment to others. Learn more.
Well, you found a lot of things I missed.
Thanks again for all your help.
I really hope that I get more used to the languages and spotless itself,
so that the next PRs are smoother.
I really hope that I get more used to the languages and spotless itself,
so that the next PRs are smoother.
No worries! It's a learning experience for us all. Even I'm not completely familiar with Spotless.
Please, feel free to take your time with learning the parts of Java and Spotless that personally interest you at your own pace. @nedtwigg and I will aim to give you feedback when it matters. :)
cdf45fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fvgh Oh, I've just realised that it would be best to replace the
[ \t]
part of the regex with\s
, since that will catch all whitespace according to https://regexone.com/lesson/whitespaces.cdf45fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdf45fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, you're right! I stand corrected, and happily so. 😄
cdf45fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdf45fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are very welcome @fvgh. 😃
No worries! It's a learning experience for us all. Even I'm not completely familiar with Spotless.
Please, feel free to take your time with learning the parts of Java and Spotless that personally interest you at your own pace. @nedtwigg and I will aim to give you feedback when it matters. :)