Update Spotbugs to 4.9.3 for Java 24 support

Goooler · Goooler · commit e1b0d61b722a · 2025-04-28T11:50:18.000+08:00
https://github.com/spotbugs/spotbugs/releases/tag/4.9.3
diff --git a/gradle/java-setup.gradle b/gradle/java-setup.gradle
@@ -23,6 +23,8 @@ spotbugs {
 		// https://spotbugs.readthedocs.io/en/latest/detectors.html#findreturnref
 		'FindReturnRef',
 	]
+	// TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360
+	toolVersion = '4.9.3'
 }
 tasks.named('spotbugsTest') {
 	enabled = false
diff --git a/lib-extra/build.gradle b/lib-extra/build.gradle
@@ -102,4 +102,6 @@ p2deps {
 spotbugs {
 	// LOW|MEDIUM|DEFAULT|HIGH (low = sensitive to even minor mistakes).
 	reportLevel = com.github.spotbugs.snom.Confidence.valueOf('LOW')
+	// TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360
+	toolVersion = '4.9.3'
 }
diff --git a/lib/build.gradle b/lib/build.gradle
@@ -138,6 +138,8 @@ dependencies {
 spotbugs {
 	// LOW|MEDIUM|DEFAULT|HIGH (low = sensitive to even minor mistakes).
 	reportLevel = com.github.spotbugs.snom.Confidence.valueOf('LOW')
+	// TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360
+	toolVersion = '4.9.3'
 }
 
 apply from: rootProject.file('gradle/special-tests.gradle')
diff --git a/testlib/build.gradle b/testlib/build.gradle
@@ -27,6 +27,8 @@ dependencies {
 spotbugs {
 	// LOW|MEDIUM|DEFAULT|HIGH (low = sensitive to even minor mistakes).
 	reportLevel = com.github.spotbugs.snom.Confidence.valueOf('HIGH')
+	// TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360
+	toolVersion = '4.9.3'
 }
 
 apply from: rootProject.file('gradle/special-tests.gradle')

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@ spotbugs {`
`23`	`23`	`// https://spotbugs.readthedocs.io/en/latest/detectors.html#findreturnref`
`24`	`24`	`'FindReturnRef',`
`25`	`25`	`]`
	`26`	`+ // TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360`
	`27`	`+ toolVersion = '4.9.3'`
`26`	`28`	`}`
`27`	`29`	`tasks.named('spotbugsTest') {`
`28`	`30`	`enabled = false`
Original file line number	Diff line number	Diff line change
`@@ -102,4 +102,6 @@ p2deps {`
`102`	`102`	`spotbugs {`
`103`	`103`	`// LOW\|MEDIUM\|DEFAULT\|HIGH (low = sensitive to even minor mistakes).`
`104`	`104`	`reportLevel = com.github.spotbugs.snom.Confidence.valueOf('LOW')`
	`105`	`+ // TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360`
	`106`	`+ toolVersion = '4.9.3'`
`105`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,8 @@ dependencies {`
`138`	`138`	`spotbugs {`
`139`	`139`	`// LOW\|MEDIUM\|DEFAULT\|HIGH (low = sensitive to even minor mistakes).`
`140`	`140`	`reportLevel = com.github.spotbugs.snom.Confidence.valueOf('LOW')`
	`141`	`+ // TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360`
	`142`	`+ toolVersion = '4.9.3'`
`141`	`143`	`}`
`142`	`144`
`143`	`145`	`apply from: rootProject.file('gradle/special-tests.gradle')`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ dependencies {`
`27`	`27`	`spotbugs {`
`28`	`28`	`// LOW\|MEDIUM\|DEFAULT\|HIGH (low = sensitive to even minor mistakes).`
`29`	`29`	`reportLevel = com.github.spotbugs.snom.Confidence.valueOf('HIGH')`
	`30`	`+ // TODO: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/1360`
	`31`	`+ toolVersion = '4.9.3'`
`30`	`32`	`}`
`31`	`33`
`32`	`34`	`apply from: rootProject.file('gradle/special-tests.gradle')`