Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing the formatJavadoc flag to Google Java Formatter #614

Closed
coyotesqrl opened this issue Jun 18, 2020 · 6 comments
Closed

Allow passing the formatJavadoc flag to Google Java Formatter #614

coyotesqrl opened this issue Jun 18, 2020 · 6 comments

Comments

@coyotesqrl
Copy link

Back in November, the Google Java Formatter was updated to support turning off formatting of javadocs. This is particularly useful functionality with newer javadoc trends as well as older codebases that include heterogenous license headers.

Here is the PR that added the functionality: google/google-java-format#418

@nedtwigg
Copy link
Member

Happy to take a PR for this (useful guide pr: #193).

If you'd like to gradually unify the license headers, without ever having a history-clobbering "format-the-world" moment, maybe try ratchetFrom 'origin/main'.

@fcurts
Copy link

fcurts commented Jul 17, 2021

Is there a workaround/hack for this? We can't adopt the Google formatter without this, as it unnecessarily changes the Javadoc in our entire codebase.

@nedtwigg
Copy link
Member

The PR referenced above (#193) is a very similar situation. To my knowledge, no workaround besides a PR.

@fcurts
Copy link

fcurts commented Jul 20, 2021

Is it possible to support a generic way to pass options so that users aren't blocked every time a new option is added?

@nedtwigg
Copy link
Member

Maybe! PR's welcome :)

@Goooler
Copy link
Member

Goooler commented Sep 28, 2023

Closed by #1793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants