-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm task up-to-date checking too slow #766
Comments
I think this is because of an Agreed that npm is slow, but I don't see much that Spotless can do about it. I suppose we could look at adding support for yarn, but I'm not sure how much better that would be. |
This happens every single time, the time varies but it usually takes around 20-30 secs or more. |
Related to #675 |
I can confirm, that in my local tests, running My configuration is following. I don't know if the dev-dependency has any impact on the performance, but my goal would be to use prettier for Java formatting, hence the setup:
|
@simschla just did a ton of work which shipped in |
We've had huge changes to this stuff, much faster now in my experience. |
summary of problem
After adding a custom task for yaml linting using prettier the task spotlessInternalRegisterDependencies does take from 10sec to more than 1min.
This is the task definition:
gradle or maven version
Gradle wrapper 6.7.1 and npm 6.14.7 as prettier does need it
spotless version
5.8.2
operating system and version
MacOs Catalina 10.15.7
traces of the step
In this case it took 23s to run:
The text was updated successfully, but these errors were encountered: