Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we are running CI on Java 8 #930

Closed
nedtwigg opened this issue Sep 6, 2021 · 2 comments
Closed

Make sure we are running CI on Java 8 #930

nedtwigg opened this issue Sep 6, 2021 · 2 comments
Labels

Comments

@nedtwigg
Copy link
Member

nedtwigg commented Sep 6, 2021

I think that we're running CI tests on Java 8 like so

executor:
name: win/default
shell: cmd.exe
steps:
- checkout
- run:
name: install
command: choco install ojdkbuild8
- run:
name: gradlew check
command: gradlew check --build-cache -PSPOTLESS_EXCLUDE_MAVEN=true

along with the NPM-only tests here

test_npm_8:
<< : *env_gradle
environment:
# java doesn't play nice with containers, it tries to hog the entire machine
# https://circleci.com/blog/how-to-handle-java-oom-errors/
# try the experimental JVM option
_JAVA_OPTIONS: "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap"
docker:
- image: cimg/openjdk:8.0-node
steps:
- checkout
- *restore_cache_wrapper
- *restore_cache_deps
- run:
name: gradlew npmTest
command: ./gradlew npmTest --build-cache

@tbroyer pointed out that if that were the case, this test (ecca2b8) should have been failing for months.

We should track this down someday to confirm what's going on.

@nedtwigg
Copy link
Member Author

Along these same lines, the test results from test_npm_8 aren't getting slurped by CircleCI properly, as discovered in #900. We fix that too.

@nedtwigg
Copy link
Member Author

Also, we should adopt https://github.com/gradle/test-retry-gradle-plugin so we can spend less time on flaky test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant