Skip to content

Commit 74e1401

Browse files
authored
small tweak to comments by simon
1 parent 4b551bc commit 74e1401

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

tests/integration_test.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,8 @@ def test_applycutoff_range1(self):
105105
self.test_gui.qminentry.insert(0, "10")
106106
self.test_gui.qmaxentry.insert(0, "40")
107107

108-
# surpressed RuntimeWarning so warning isn't generated when test encounters slice of all NaNs
108+
# Desired behavior is nans in the arrays below qmin and above qmax. As a result, np.nanmax will generate runtimewarnings when it
109+
# encounters slices that are all nans. capture these so tests pass cleanly without warnings
109110
with warnings.catch_warnings():
110111
warnings.simplefilter("ignore", category=RuntimeWarning)
111112
# when
@@ -121,8 +122,9 @@ def test_applycutoff_range2(self):
121122
self.test_gui.cube = self.test_sofq
122123
self.test_gui.qminentry.insert(0, "15")
123124
self.test_gui.qmaxentry.insert(0, "35")
124-
125-
# surpressed RuntimeWarning so warning isn't generated when test encounters slice of all NaNs
125+
126+
# Desired behavior is nans in the arrays below qmin and above qmax. As a result, np.nanmax will generate runtimewarnings when it
127+
# encounters slices that are all nans. capture these so tests pass cleanly without warnings
126128
with warnings.catch_warnings():
127129
warnings.simplefilter("ignore", category=RuntimeWarning)
128130
# when

0 commit comments

Comments
 (0)