Skip to content

Conversation

@alisnwu
Copy link
Contributor

@alisnwu alisnwu commented Oct 11, 2024

Added build-wheel-release-upload.yml to workflows

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline

workflow_dispatch:
push:
tags:
- '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make a release for any tag I guess so we need a better Regen. Is this still testing or I should be reviewing this for production?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still testing, sorry I forgot to close this pull request will close it rn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on:
  push:
    tags:
      - '[0-9]+.[0-9]+.[0-9]+*'  # Match tags that start with digit.digit.digit and may have additional qualifiers

The above may work

@alisnwu alisnwu closed this Oct 12, 2024
@sbillinge sbillinge reopened this Oct 16, 2024
@sbillinge sbillinge merged commit 2f39a1d into diffpy:main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants