Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button icon only - smarter solutions? #2512

Open
mimarz opened this issue Sep 25, 2024 · 1 comment
Open

Button icon only - smarter solutions? #2512

mimarz opened this issue Sep 25, 2024 · 1 comment
Labels
css @digdir/designsystemet-css react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 25, 2024

If using Button with icon only, we now require developers to also remember adding icon={true} to the button as padding-adjustments for icon-only is not possible to do via CSS. Is this okay, or should we talk about alternative approaches? :)
@mimarz mimarz converted this from a draft issue Sep 25, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Sep 25, 2024

revisit this after #2508

@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 25, 2024
@mimarz mimarz added react @digdir/designsystemet-react css @digdir/designsystemet-css labels Sep 25, 2024
@mimarz mimarz added this to the V1 - Helhetlig komponentbibliotek milestone Oct 28, 2024
@eirikbacker eirikbacker mentioned this issue Nov 1, 2024
Merged
@mrosvik mrosvik removed this from the Helhetlig komponentbibliotek milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css @digdir/designsystemet-css react @digdir/designsystemet-react
Projects
Team Design System
Status: 📄 Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mimarz @mrosvik