Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert adjustments: Update with border inside and spacing-4 #531

Closed
mrosvik opened this issue Jun 9, 2023 · 0 comments · Fixed by #532
Closed

Alert adjustments: Update with border inside and spacing-4 #531

mrosvik opened this issue Jun 9, 2023 · 0 comments · Fixed by #532
Assignees
@framitdavid
Labels
react @digdir/designsystemet-react

Comments

@mrosvik
Copy link
Member

mrosvik commented Jun 9, 2023 •
edited
Loading

Vi kan ikke ha borderen på utsiden allikevel i Figma, da blir den plassert feil i forhold til resten av innholdet i et skjema f.eks. Det har derfor blitt endret til inside i Figma og byttet spacing left fra 2 til 4 slik at denne blir korrekt. Da blir det spacing-4 på alle sider i Figma.

Vi burde fikse dette i kode og da det vil bli “skjevt” her og når du prøver å aligne. Kan kanskje fikses med å ender box-sizing slik at border kommer på innsiden.
@mrosvik mrosvik converted this from a draft issue Jun 9, 2023
@mrosvik mrosvik changed the title Alert: Update with border inside and spacing-4 Alert adjustments: Update with border inside and spacing-4 Jun 9, 2023
@mrosvik mrosvik added react @digdir/designsystemet-react component labels Jun 9, 2023
@framitdavid framitdavid moved this from 📄 Todo to 🏗 In progress in Team Design System Jun 9, 2023
@framitdavid framitdavid mentioned this issue Jun 9, 2023
Merged
@framitdavid framitdavid moved this from 🏗 In progress to 👀 Ready for review in Team Design System Jun 9, 2023
@framitdavid framitdavid moved this from 👀 Ready for review to ✅ Done in Team Design System Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@framitdavid framitdavid

Labels
react @digdir/designsystemet-react
Projects
Team Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(Alert): use box-shadow as border-left digdir/designsystemet
2 participants
@mrosvik @framitdavid