Skip to content

Commit 0a4331a

Browse files
authored
fix(slack-notifier): exclude health checks from alerts (#1335)
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Logging has changed a bit so need to change the endpoint to exclude from alerts. We don't want to log the health-check endpoint traces, but that has to be tweaked in another PR ## Related Issue(s) - N/A Slack discussion: https://digdir.slack.com/archives/C079XRW5G5A/p1729643530959569 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced alerting logic for the Slack Notifier function app to broaden the scope of monitored requests. - Defined SKU parameters to ensure valid options for resource deployment. - **Bug Fixes** - Adjusted criteria for exception alerting to improve monitoring accuracy. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 6b926f4 commit 0a4331a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.azure/modules/functionApp/slackNotifier.bicep

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ var query = '''
162162
| where type != "ZiggyCreatures.Caching.Fusion.SyntheticTimeoutException"),
163163
(traces
164164
| where severityLevel >= 3 or (severityLevel >= 2 and customDimensions.SourceContext startswith "Digdir"))
165-
| where operation_Name !startswith "GET /health/"
165+
| where customDimensions.RequestPath !startswith "/health"
166166
| summarize Count = count()
167167
by
168168
Environment = tostring(customDimensions.AspNetCoreEnvironment),

0 commit comments

Comments
 (0)