fix: Upgraded Altinn.ApiClients.Maskinporten, specify TokenExchangeEnvironment #1328
Conversation
…ment under Maskinporten in appsettings
📝 WalkthroughWalkthroughThis pull request includes updates to the project configuration and settings files for the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.yt01.json (1)
19-20: LGTM! Consider adding a comment for clarity.The addition of the
TokenExchangeEnvironmentproperty is correct and aligns with the PR objectives. The value "yt01" is consistent with the file name, which is good.Consider adding a brief comment above the
TokenExchangeEnvironmentproperty to explain its purpose and potential values. For example:"Maskinporten": { // ... other properties ... "EncodedJwk": "TODO: Add to local secrets", // Specifies the environment for token exchange (e.g., "yt01", "tt02", "prod") "TokenExchangeEnvironment": "yt01" }This would improve the maintainability and clarity of the configuration file.
🧰 Tools
🪛 Biome
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (6)
- src/Digdir.Domain.Dialogporten.Infrastructure/Digdir.Domain.Dialogporten.Infrastructure.csproj (1 hunks)
- src/Digdir.Domain.Dialogporten.WebApi/appsettings.Development.json (1 hunks)
- src/Digdir.Domain.Dialogporten.WebApi/appsettings.prod.json (1 hunks)
- src/Digdir.Domain.Dialogporten.WebApi/appsettings.staging.json (1 hunks)
- src/Digdir.Domain.Dialogporten.WebApi/appsettings.test.json (1 hunks)
- src/Digdir.Domain.Dialogporten.WebApi/appsettings.yt01.json (2 hunks)
🧰 Additional context used
🪛 Biome
src/Digdir.Domain.Dialogporten.WebApi/appsettings.Development.json
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.prod.json
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.staging.json
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.test.json
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.yt01.json
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
🔇 Additional comments (5)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.prod.json (1)
19-20: LGTM: TokenExchangeEnvironment correctly specified for production.The addition of the "TokenExchangeEnvironment" property with the value "prod" in the Maskinporten section is appropriate for the production environment. This change aligns with the PR objectives and is consistent with the updates mentioned in the summary.
To ensure consistency across all environment files, please run the following script:
✅ Verification successful
[/run_scripts]
Verified: TokenExchangeEnvironment correctly configured across all environments.
All appsettings files have the "TokenExchangeEnvironment" property set correctly for their respective environments.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify TokenExchangeEnvironment across all appsettings files # Test: Check TokenExchangeEnvironment in all appsettings files echo "Checking TokenExchangeEnvironment in appsettings files:" rg -A 1 '"Maskinporten"' src/Digdir.Domain.Dialogporten.WebApi/appsettings*.json # Expected output: # prod.json: "TokenExchangeEnvironment": "prod" # Development.json: "TokenExchangeEnvironment": "tt02" # staging.json: "TokenExchangeEnvironment": "tt02" # test.json: "TokenExchangeEnvironment": "tt02" # yt01.json: "TokenExchangeEnvironment": "yt01"Length of output: 2739
Script:
#!/bin/bash # Description: Verify the presence and values of TokenExchangeEnvironment in all appsettings files echo "Verifying TokenExchangeEnvironment in appsettings files:" fd "appsettings.*.json" src/Digdir.Domain.Dialogporten.WebApi/ | xargs grep -H '"TokenExchangeEnvironment"'Length of output: 747
🧰 Tools
🪛 Biome
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 19-19: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.staging.json (1)
22-23: LGTM: TokenExchangeEnvironment added as specified.The addition of
"TokenExchangeEnvironment": "tt02"in the Maskinporten section aligns with the PR objectives. The value "tt02" is appropriate for the staging environment.Let's verify the consistency of this configuration across different environment files:
✅ Verification successful
Verified: TokenExchangeEnvironment is consistently set across all environment files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check TokenExchangeEnvironment across different environment files # Test: Verify TokenExchangeEnvironment in different appsettings files echo "Checking TokenExchangeEnvironment in different appsettings files:" fd appsettings.*json$ --exec grep -H '"TokenExchangeEnvironment"' {} \;Length of output: 744
🧰 Tools
🪛 Biome
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.WebApi/appsettings.test.json (1)
22-23: LGTM: New TokenExchangeEnvironment configuration added.The addition of the "TokenExchangeEnvironment" configuration with the value "tt02" aligns with the PR objectives and is appropriate for the test environment.
To ensure consistency across different environment configurations, please run the following script:
Remember to replace the "TODO" placeholders in this file with actual values using a secure method, such as local secrets or a secure key management system.
✅ Verification successful
Verified: TokenExchangeEnvironment is consistently set across all appsettings files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify TokenExchangeEnvironment values across different appsettings files # Test: Check TokenExchangeEnvironment values in all appsettings files echo "TokenExchangeEnvironment values in appsettings files:" rg -g 'appsettings*.json' '"TokenExchangeEnvironment"' src/Digdir.Domain.Dialogporten.WebApi/Length of output: 727
🧰 Tools
🪛 Biome
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
src/Digdir.Domain.Dialogporten.Infrastructure/Digdir.Domain.Dialogporten.Infrastructure.csproj (1)
4-4: LGTM: Package version update looks good.The update of Altinn.ApiClients.Maskinporten from version 9.1.0 to 9.2.1 aligns with the PR objectives. This change is likely to bring improvements or bug fixes.
To ensure this update doesn't introduce any conflicts, please run the following verification script:
Additionally, as mentioned in the PR objectives, please ensure that manual testing has been conducted to verify the functionality with the updated package.
src/Digdir.Domain.Dialogporten.WebApi/appsettings.Development.json (1)
22-23: LGTM! Consider documenting the new configuration.The addition of
"TokenExchangeEnvironment": "tt02"aligns with the PR objectives to specify the TokenExchangeEnvironment. This change looks good and should improve the integration with Maskinporten.To ensure consistency across environments, please run the following script:
Consider adding a comment or updating the documentation to explain the purpose of
TokenExchangeEnvironmentand its possible values (e.g., "tt02", "yt01", "prod"). This will help other developers understand the configuration's impact.As mentioned in the PR objectives, documentation updates are pending. Would you like assistance in drafting documentation for this new configuration option?
✅ Verification successful
TokenExchangeEnvironment configuration verified and consistent across all environments.
All environments have the correct TokenExchangeEnvironment values:
- Development: tt02
- Test: tt02
- Staging: tt02
- yt01: yt01
- Production: prod
This ensures proper configuration alignment as per the PR objectives.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify TokenExchangeEnvironment values across different environment configurations # Test: Check TokenExchangeEnvironment values in all appsettings files echo "TokenExchangeEnvironment values in different environments:" rg -g 'appsettings*.json' '"TokenExchangeEnvironment":\s*"([^"]*)"' -o -r '$1'Length of output: 542
🧰 Tools
🪛 Biome
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
[error] 22-22: End of file expected
Use an array for a sequence of values:
[1, 2](parse)
🤖 I have created a release *beep* *boop* --- ## [1.26.0](v1.25.0...v1.26.0) (2024-10-22) ### Features * Add masstransit outbox system ([#1277](#1277)) ([bc04860](bc04860)) ### Bug Fixes * **infrastructure:** use correct networking for servicebus ([#1320](#1320)) ([4fb42bb](4fb42bb)) * Return distinct actions in GetAlinnActions ([#1298](#1298)) ([49948b2](49948b2)) * Upgraded Altinn.ApiClients.Maskinporten, specify TokenExchangeEnvironment ([#1328](#1328)) ([5156799](5156799)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Upgraded Altinn.ApiClients.Maskinporten, specify TokenExchangeEnvironment under Maskinporten in appsettings
Description
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit
New Features
TokenExchangeEnvironment, across multiple environment settings (development, production, staging, test, and yt01) for enhanced token exchange configuration.Updates
Altinn.ApiClients.Maskinportenpackage to9.2.1.